[DX] Define list of allowed implicit commands on ConsoleApplication#7918
Merged
TomasVotruba merged 7 commits intomainfrom Mar 1, 2026
Merged
[DX] Define list of allowed implicit commands on ConsoleApplication#7918TomasVotruba merged 7 commits intomainfrom
TomasVotruba merged 7 commits intomainfrom
Conversation
Member
Author
|
@TomasVotruba ready 👍 |
samsonasik
force-pushed
the
dx-define-allowed-commands
branch
from
4f85941 to
62328c7
Compare
Member
Author
|
Rebased and refactored to early return on null on command name 👍 Ready to merge 👍 |
TomasVotruba
reviewed
Mar 1, 2026
src/Console/ConsoleApplication.php
Outdated
| /** | ||
| * @var string[] | ||
| */ | ||
| private const array ALLOWED_COMMANDS = [ |
Member
There was a problem hiding this comment.
I think this should be dynamic, so we don't have to maintain it. There is already list of commands available here.
Member
Author
There was a problem hiding this comment.
@TomasVotruba sure, updated to use $this->has() method call check 👍 21caaf8
should be dynamically ok now 👍
Member
|
Thank you, looks good 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9677
@MrYamous @TomasVotruba this should make more clear message that passed argument is an allowed implicit commands.
Before
After